Avoid shipping internal musl headers as part of the sysroot#26658
Avoid shipping internal musl headers as part of the sysroot#26658sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
b77b9aa to
30cab7e
Compare
|
The BTW, are API-incompatible changes in the |
It turns out that the files in `musl/arch/generic/` and `musl/arch/emscripten/` are internal headers even though the `bits/` subdirectories are public. This change did mean that `syscall_arch.h` is not longer visible to the wasmfs build so I moved the public function declarations to `emscripten/syscalls.h`.
30cab7e to
bba540c
Compare
Fixed.
I mean.. we can always make ABI-incompatible changes if we deem it worth it (i.e. the impact is low and the benefit is high). Hopefully the number of users of |
|
Great!
Indeed. AFAIK, after PR #24655 only |
It turns out that the files in
musl/arch/generic/andmusl/arch/emscripten/are supposed to me internal headers even though thebits/subdirectories are public.This change means that
syscall_arch.his not longer visible outside of the musl build (e.g. when building wasmfs) so I moved the public function declarations toemscripten/syscalls.h.