Skip to content

Emsymbolizer: Remove VMA adjustment from llvm-symbolizer call#26665

Merged
dschuff merged 3 commits intoemscripten-core:mainfrom
dschuff:emsymbolize_adjust
Apr 10, 2026
Merged

Emsymbolizer: Remove VMA adjustment from llvm-symbolizer call#26665
dschuff merged 3 commits intoemscripten-core:mainfrom
dschuff:emsymbolize_adjust

Conversation

@dschuff
Copy link
Copy Markdown
Member

@dschuff dschuff commented Apr 9, 2026

After llvm/llvm-project#191068 it is no longer
necessary (or correct).

@dschuff dschuff requested a review from aheejin April 10, 2026 00:10
@dschuff
Copy link
Copy Markdown
Member Author

dschuff commented Apr 10, 2026

@sbc100 This is going to have to be synchronized because it depends on llvm/llvm-project#191329 to pass. What's our usual procedure here, just disable the test until the rollers call catch up?

@dschuff
Copy link
Copy Markdown
Member Author

dschuff commented Apr 10, 2026

(what's the current way to disable a test completely?)

@dschuff dschuff changed the title Emsymbolizer: Remove VMA adjustment from llvm-symblizer call Emsymbolizer: Remove VMA adjustment from llvm-symbolizer call Apr 10, 2026
Copy link
Copy Markdown
Member

@aheejin aheejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can wait for llvm/llvm-project#191068 to land in the roller and land this?

@dschuff
Copy link
Copy Markdown
Member Author

dschuff commented Apr 10, 2026

I think you can wait for llvm/llvm-project#191068 to land in the roller and land this?

Actually the problem is llvm/llvm-project#191329. With that patch applied the emsymbolizer tests don't pass unless the VMA adjustment is removed. The fact that this test accidentally passes with #191068 applied is what made me discover the issue that #191329 fixes.

@sbc100
Copy link
Copy Markdown
Collaborator

sbc100 commented Apr 10, 2026

Yes we just disable the tests while the roll happens normally.

@dschuff dschuff enabled auto-merge (squash) April 10, 2026 18:42
@dschuff dschuff merged commit 4c4c5d4 into emscripten-core:main Apr 10, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants