Emsymbolizer: Remove VMA adjustment from llvm-symbolizer call#26665
Emsymbolizer: Remove VMA adjustment from llvm-symbolizer call#26665dschuff merged 3 commits intoemscripten-core:mainfrom
Conversation
After llvm/llvm-project#191068 it is no longer necessary (or correct).
|
@sbc100 This is going to have to be synchronized because it depends on llvm/llvm-project#191329 to pass. What's our usual procedure here, just disable the test until the rollers call catch up? |
|
(what's the current way to disable a test completely?) |
aheejin
left a comment
There was a problem hiding this comment.
I think you can wait for llvm/llvm-project#191068 to land in the roller and land this?
Actually the problem is llvm/llvm-project#191329. With that patch applied the emsymbolizer tests don't pass unless the VMA adjustment is removed. The fact that this test accidentally passes with #191068 applied is what made me discover the issue that #191329 fixes. |
|
Yes we just disable the tests while the roll happens normally. |
After llvm/llvm-project#191068 it is no longer
necessary (or correct).