Remove special case from pthread_kill.#26668
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Apr 11, 2026
Merged
Conversation
This special handling for SIGCANCEL should not be needed. If we need to do something like `_emscripten_runtime_keepalive_clear` during pthread cancelation it would be best done when the cancellation in processed in `__testcancel`/`__cancel`. The comment and code I'm removing here was added back in emscripten-core#22467 along with testing in the form of `test/pthread/test_pthread_kill.c` and the pthread_kill tests in posixtest. I recently expanded the testing in emscripten-core#26663, and this change doesn't break any of those tests.
tlively
approved these changes
Apr 11, 2026
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
I don't have a good understanding of all the context about how threads are canceled, but the code LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This special handling for
SIGCANCELshould not be needed. If we need to do something like_emscripten_runtime_keepalive_clearduring pthread cancelation it would be best done when the cancellation in processed in__testcancel/__cancel.The comment & code I'm removing here was added back in #22467 along with testing in the form of
test/pthread/test_pthread_kill.cand the pthread_kill tests in posixtest.I recently expanded the testing in #26663, and this change doesn't break any of those tests.