Fix unquote IndexError on empty string input#3771
Open
bysiber wants to merge 1 commit intoencode:masterfrom
Open
Fix unquote IndexError on empty string input#3771bysiber wants to merge 1 commit intoencode:masterfrom
unquote IndexError on empty string input#3771bysiber wants to merge 1 commit intoencode:masterfrom
Conversation
`unquote('')` raises `IndexError` because it accesses `value[0]`
without checking the string length first. This can occur when parsing
digest auth WWW-Authenticate headers containing parameters with empty
unquoted values (e.g. `realm=` instead of `realm=""`).
akx
reviewed
Feb 24, 2026
|
|
||
| def unquote(value: str) -> str: | ||
| return value[1:-1] if value[0] == value[-1] == '"' else value | ||
| if len(value) >= 2 and value[0] == value[-1] == '"': |
There was a problem hiding this comment.
Suggested change
| if len(value) >= 2 and value[0] == value[-1] == '"': | |
| if value and value[0] == value[-1] == '"': |
to avoid a global lookup, a function call and a comparison...?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unquote('')in_utils.pyraisesIndexErrorbecause it accessesvalue[0]without checking string length first.This can occur when parsing digest auth
WWW-Authenticateheaders containing parameters with empty unquoted values (e.g.realm=instead ofrealm="").