Skip to content

Quiesce warnings from grep in sync-version#3776

Open
akx wants to merge 1 commit intoencode:masterfrom
akx:quiesce-grep-warnings
Open

Quiesce warnings from grep in sync-version#3776
akx wants to merge 1 commit intoencode:masterfrom
akx:quiesce-grep-warnings

Conversation

@akx
Copy link

@akx akx commented Feb 24, 2026

Summary

(?:...) non-capturing groups are a PCRE thing, not a grep ERE thing.

As we can see in e.g. GitHub Actions runs, sync-version as of current main throws six (count 'em!) warnings when run. (Looks like this warning was added into GNU tools some 4 years ago.)

Run scripts/check
+ ./scripts/sync-version
grep: warning: ? at start of expression
grep: warning: ? at start of expression
grep: warning: ? at start of expression
grep: warning: ? at start of expression
grep: warning: ? at start of expression
grep: warning: ? at start of expression
CHANGELOG_VERSION: 0.28.1
VERSION: 0.28.1

This removes the ?:, so no more warnings, still the same grep power.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
    • No tests required.
  • I've updated the documentation accordingly.
    • No documentation updates required.

(?:...) non-capturing groups are a PCRE thing, not a grep ERE thing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant