Upgrade to Godot 4.7#2420
Merged
Merged
Conversation
Update project.godot. Run the editor's tool to upgrade all scenes and resources. Update the CI workflow, factoring out the Godot export version to a top-level environment variable because it was previously out of synch between Web and Windows! Do not update the Flatpak build for now due to: - flathub/org.godotengine.godot.BaseApp#76 Increase the line width in the splash screen to compensate for [a change documented in the release notes][0]: [0]: https://docs.godotengine.org/en/4.7/tutorials/migrating/upgrading_to_godot_4.7.html#id2 > CanvasItem now avoids adding the antialiasing feather when drawing > lines (GH-105122). The feather made lines appear thicker than > intended, projects that relied on this behavior will have to be > updated to draw a thicker line width. Having reviewed the release notes & tested the game somewhat I believe this is the only change that will bite us. There is a note about changing the reported device ID for keyboard/mouse from 0 to `InputEvent.DEVICE_ID_MOUSE` and `InputEvent.DEVICE_ID_KEYBOARD`; `InputHelper` hardcodes setting the last device index to `-1` on receiving keyboard/mouse input, so this upstream change doesn't change anything for us. Resolves #2418
3762347 to
fc03622
Compare
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/upgrade-to-godot-4-7/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Jun 22, 2026
manuq
left a comment
Collaborator
There was a problem hiding this comment.
I played through the tutorial + musician quest and couldn't find anything odd.
The splash looks good now, at least in my screen resolution.
Comment on lines
-46
to
+47
| godot_version: "4.6.3" | ||
| godot_version: ${{ env.GODOT_VERSION }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update project.godot.
Run the editor's tool to upgrade all scenes and
resources.
Update the CI workflow, factoring out the Godot export version to a
top-level environment variable because it was previously out of synch
between Web and Windows!
Do not update the Flatpak build for now due to:
Increase the line width in the splash screen to compensate for a change
documented in the release notes:
Having reviewed the release notes & tested the game somewhat I believe
this is the only change that will bite us. There is a note about
changing the reported device ID for keyboard/mouse from 0 to
InputEvent.DEVICE_ID_MOUSEandInputEvent.DEVICE_ID_KEYBOARD;InputHelperhardcodes setting the last device index to-1onreceiving keyboard/mouse input, so this upstream change doesn't change
anything for us.
Resolves #2418