Skip to content

Cache ZoneId in ZonedDateTimeAdapter to reduce allocation pressure #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vpaturet merged 1 commit into from
Feb 27, 2026
Merged

Cache ZoneId in ZonedDateTimeAdapter to reduce allocation pressure #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/java/org/entur/siri/adapter/ZonedDateTimeAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@

public class ZonedDateTimeAdapter {

private static final ZoneId DEFAULT_ZONE = ZoneId.systemDefault();
private static final ZoneOffset ZERO_OFFSET = ZoneOffset.ofHours(0);

/**
* Parses dateTime to ZonedDateTime with optional zone.
* If Zone is not provided, local system default is used.
Expand All @@ -35,10 +38,10 @@ public static ZonedDateTime parse(String dateTime) {
parsed = ZonedDateTime.parse(dateTime);
} catch (DateTimeParseException e) {
LocalDateTime parse1 = LocalDateTime.parse(dateTime, DateTimeFormatter.ISO_LOCAL_DATE_TIME);
parsed = ZonedDateTime.ofLocal(parse1, ZoneId.systemDefault(), ZoneOffset.ofHours(0));
parsed = ZonedDateTime.ofLocal(parse1, DEFAULT_ZONE, ZERO_OFFSET);

}
return parsed.withZoneSameInstant(ZoneId.systemDefault());
return parsed.withZoneSameInstant(DEFAULT_ZONE);
}

}
Loading