istio: migrate all istio extensions to contrib #42785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates all Istio extensions from the istio/proxy repository to Envoy's contrib directory. The migration includes four main filters (metadata_exchange, peer_metadata, istio_stats, alpn) along with common utilities for workload discovery and metadata objects. As stated in the PR description, the code changes are minimal (style/format fixes only), API changes preserve legacy package names for backward compatibility, and only unit tests are migrated.
Key Changes:
- Adds Istio-specific network and HTTP filters to contrib
- Preserves legacy package names for backward compatibility (e.g.,
istio.envoy.config.filter.http.alpn.v2alpha1) - Includes comprehensive test coverage for the migrated components
Reviewed changes
Copilot reviewed 54 out of 54 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/type_whisperer/proto_build_targets_gen.py | Adds support for non-standard versioned packages used by Istio extensions |
| tools/code_format/config.yaml | Exempts specific Istio files from certain formatting rules |
| contrib/extensions_metadata.yaml | Registers all four Istio extensions with proper metadata |
| contrib/contrib_build_config.bzl | Adds build configuration for Istio extensions |
| CODEOWNERS | Assigns ownership of Istio contrib directory |
| changelogs/current.yaml | Documents the migration in release notes |
| api/contrib/envoy/extensions/filters//v3/.proto | Proto definitions for all Istio filters |
| contrib/istio/filters//source/ | Source implementations for all filters |
| contrib/istio/filters//test/ | Unit tests for all filters |
| docs/root/api-v3/config/contrib/istio/istio.rst | Documentation index for Istio extensions |
contrib/istio/filters/network/metadata_exchange/source/metadata_exchange.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Signed-off-by: code <wbphub@gmail.com>
agrawroh
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: istio: migrate all istio extensions to contrib
Additional Description:
See #29681 for more context.
All these come from github.com/istio/proxy.
For the code: no any change except fixing style and format.
For the API: no any change except fixing format. The legacy package name is kept for backward compatibility, for example, for the ALPN filter, the type url
istio.envoy.config.filter.http.alpn.v2alpha1.FilterConfigwill still be used.. We should try to figure out a possible way to migrate to new Envoy standard API.For the test: only unit tests are migrated. The e2e tests are still kept in the istio/proxy. We can add more unit tests and integration tests for these extensions in the future.
Risk Level: low. Mainly contrib change and harmless to Envoy self.
Testing: n/a.
Docs Changes: n/a.
Release Notes: added.
Platform Specific Features: n/a.