feat: add minContentLength support for compression #7799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for configuring minimum response size for compression in BackendTrafficPolicy. - Added MinContentLength field with validation (min 30 bytes) - Updated IR and XDS translator - Added tests Fixes envoyproxy#7781 Signed-off-by: Rajat Vig <rvig@etsy.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7799 +/- ##
==========================================
+ Coverage 72.79% 72.83% +0.03%
==========================================
Files 235 235
Lines 35176 35189 +13
==========================================
+ Hits 25606 25629 +23
+ Misses 7754 7747 -7
+ Partials 1816 1813 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rajatvig
force-pushed
the
feat/compression-min-content-length
branch
from
5ebaf3e to
446dcb6
Compare
Signed-off-by: Rajat Vig <rvig@etsy.com>
rajatvig
force-pushed
the
feat/compression-min-content-length
branch
from
446dcb6 to
abeaa9f
Compare
zirain
changed the title
Contributor
|
/retest |
jukie
reviewed
Dec 26, 2025
Contributor
|
Could you also update the backendtrafficpolicy testdata with an example inside |
Signed-off-by: Rajat Vig <rvig@etsy.com>
…n-content-length Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
…n-content-length Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
Member
|
/retest |
zirain
approved these changes
Jan 7, 2026
zirain
approved these changes
Jan 7, 2026
kkk777-7
reviewed
Jan 7, 2026
| route: | ||
| cluster: httproute/default/httproute-1/rule/0 | ||
| upgradeConfigs: | ||
| - upgradeType: websocket |
Member
There was a problem hiding this comment.
curious why disappear perFilterConfig for compressor?
Member
There was a problem hiding this comment.
found it, we should set compression field name in input file of L39.
@rajatvig
All your code looks good, just in case could you update xds testfile ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What this PR does / why we need it:
Adds
minContentLengthfield to BackendTrafficPolicy compression configuration. Allows operators to configure the minimum response size for compression, reducing CPU overhead on small responses.Which issue(s) this PR fixes:
Fixes #7781