Harden npm trusted publishing workflow#178
Merged
kentcdodds merged 7 commits intoMay 12, 2026
Merged
Conversation
kentcdodds
reviewed
May 12, 2026
kentcdodds
reviewed
May 12, 2026
Xiphe
reviewed
May 13, 2026
Comment on lines
+78
to
86
| publish: | ||
| name: 🚀 Release | ||
| needs: [build-release-artifact] | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write # to be able to publish a GitHub release | ||
| id-token: write # to enable use of OIDC for npm provenance | ||
| issues: write # to be able to comment on released issues | ||
| pull-requests: write # to be able to comment on released pull requests |
Collaborator
There was a problem hiding this comment.
What I've been doing on other projects lately is tying the OIDC on npm side to a dedicated github environment that requires review from a maintainer before being executed.
That way there's always a human in the loop with publishing. Happy to set that up and keeping an eye on it if you feel thats worth it @kentcdodds
Details
Looks like this on npm side:
-
github actions: https://github.com/cmx-tools/packages/blob/main/.github/workflows/ci.yml#L56
-
environment config
Member
There was a problem hiding this comment.
If you'd like to do that, go for it 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Triggered by the TanStack npm supply-chain compromise postmortem: https://tanstack.com/blog/npm-supply-chain-compromise-postmortem
Testing