fix: message sequence validation and improved error logging#63
Open
anson627 wants to merge 1 commit intoericc-ch:masterfrom
Open
fix: message sequence validation and improved error logging#63anson627 wants to merge 1 commit intoericc-ch:masterfrom
anson627 wants to merge 1 commit intoericc-ch:masterfrom
Conversation
Improved error response logging in src/lib/error.ts Added message sequence validation/fix for tool calls in src/routes/messages/non-stream-translation.ts 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
👍👍👍 |
Owner
|
I'll be honest haven't had much time maintaining this project. |
Author
|
after some testing, I found the error logging part is improved, but the issue is completely fixed, this is the new error I got when I chose "No, and tell Claude what to do differently " after the initial prompt, need do some more debugging and try further fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to error handling and message sequence validation in the
src/lib/error.tsandsrc/routes/messages/non-stream-translation.tsfiles. The main changes include enhancing error response processing, adding helper functions for validating and fixing message sequences, and ensuring message consistency during translation.Error Handling Improvements:
forwardErrorfunction insrc/lib/error.tsto handle error responses more robustly by cloning the response and attempting to parse both JSON and text formats. This ensures better error logging and fallback mechanisms when parsing fails.Message Sequence Validation and Fixing:
validateMessageSequenceandfixMessageSequencehelper functions insrc/routes/messages/non-stream-translation.tsto ensure that all tool calls in a message sequence have corresponding responses. Missing responses are automatically added as placeholders.Translation Enhancements:
translateToOpenAIfunction to integratefixMessageSequence, ensuring that translated messages are validated and corrected for consistency before being returned.translateAnthropicMessagesToOpenAIfunction to use a more explicit loop for processing messages, improving readability and maintainability.Improved error response logging in src/lib/error.ts Added message sequence validation/fix for tool calls in src/routes/messages/non-stream-translation.ts🤖 Generated with Claude Code
this is attempt to fix issue #62