Add low-disk and failed-job conditions to the server tab badge (#754/#749)#1128
Merged
Conversation
…749) The per-server tab badge was driven only by blocking/deadlock/CPU/memory, so a server whose only problem was a full volume or a failed Agent job showed no tab indicator -- the alert surfaced only as a one-shot tray toast and an Alert-History row. Both apps now fold the alert engine's active low-disk / failed-job state into the badge: it lights while the condition is active, auto-clears when the disk recovers or the failure ages out, and acknowledges/silences like the other badges. Persistent-indicator complement to the low-disk re-fire fix (#1127). Dashboard: HasLowDiskAlert/HasFailedJobAlert on ServerHealthStatus, injected in the UpdateTabBadge choke point from _activeLowDiskAlert/_activeFailedJobAlert, folded into HasAnyAlertCondition + the acknowledge AlertBaseline. Lite: its badge is fed by the blocking/deadlock tab refresh, a separate path from the alert sweep -- which use different server identities (GUID for tabs vs int DuckDB id for the sweep). The sweep resolves the ServerConnection via the existing deterministic-hash bridge, sets GUID-keyed badge flags, and re-renders via RefreshServerBadgeExtras with the last-known counts; UpdateAlertCounts ORs the two flags. Covered by AlertBadgeConditionTests (5 cases). Both apps build clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
erikdarlingdata
added a commit
that referenced
this pull request
Jun 16, 2026
Fix #1128 review defects before v3.0.0 tag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The per-server tab badge was driven only by blocking / deadlock / CPU / memory. A server whose only problem was a full volume or a failed Agent job showed no tab indicator — the alert surfaced only as a one-shot tray toast and an Alert-History row, so you couldn't tell which server was affected at a glance. (Reported after the low-disk re-fire fix — "low disk and failed agent jobs don't have badges, more half-done work.")
Fix (both apps)
A server's tab badge now lights up while it has an active low-disk breach or a failed Agent job in the lookback window; it auto-clears when the disk recovers / the failure ages out, and acknowledges/silences exactly like the other badges. This is the persistent-indicator complement to the low-disk re-fire fix (#1127): alert once, then stay quietly flagged instead of re-nagging.
HasLowDiskAlert/HasFailedJobAlertonServerHealthStatus, injected at the singleUpdateTabBadgechoke point from_activeLowDiskAlert/_activeFailedJobAlert, folded intoHasAnyAlertCondition+ the acknowledgeAlertBaseline.ServerConnectionvia the existing deterministic-hash bridge, sets GUID-keyed badge flags, and re-renders viaRefreshServerBadgeExtraswith the last-known counts;UpdateAlertCountsORs the two flags. Badge shows the blocking+deadlock count, or!when the only live condition is disk/job.Verification
AlertBadgeConditionTests— 5 cases (low-disk shows / failed-job shows / none hidden / acknowledge suppresses until a NEW condition / auto-clears on resolve). 5/5 pass.🤖 Generated with Claude Code