Replace stale 2.12.0 version strings with 3.0.0#1129
Merged
Conversation
This release was developed as 2.12.0 then rebumped to the 3.0.0 major; the embedded "2.12.0" strings were never updated. Most are user-facing: the Apply Fix handlers and the remediation confirm dialog told users to "Upgrade this server to 2.12.0 to enable audited Apply Fix" -- a version that will never ship (3.0.0 does create config.remediation_action_log, so the gate is satisfied; only the named version was wrong). Replaced 2.12.0 -> 3.0.0 in the 6 Apply Fix handler messages + RemediationConfirmWindow dialog text, two code comments, the Remove-OrphanedTraceFiles.ps1 doc comment, and the four upgrades/2.11.0-to-3.0.0 script headers (which still read "2.11.0 to 2.12.0"). The four Dashboard.Tests asserts pinning the literal message text were updated in lockstep. Found by the release-auditor pre-release gate. Dashboard builds clean; Dashboard.Tests 487/487 pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release was developed as
2.12.0, then rebumped to the3.0.0major — but embedded2.12.0strings were never updated. The user-facing ones are a real bug: the Apply Fix handlers + remediation confirm dialog tell users "Upgrade this server to 2.12.0 to enable audited Apply Fix" — a version that will never ship.Fix
Replaced
2.12.0→3.0.0in 17 files (26 lines, no EOL churn): 6 Apply Fix handler messages +RemediationConfirmWindowdialog text, 2 code comments, theRemove-OrphanedTraceFiles.ps1doc comment, the 4upgrades/2.11.0-to-3.0.0/script headers (still read "2.11.0 to 2.12.0"), and the 4Dashboard.Testsasserts that pin the literal text (lockstep, or build breaks).Found by the
release-auditorpre-release gate. Dashboard builds clean; Dashboard.Tests 487/487.🤖 Generated with Claude Code