fix(kademlia): set reachability status metric value to 1 instead of 0#5368
Merged
gacevicljubisa merged 1 commit intomasterfrom Feb 16, 2026
Merged
fix(kademlia): set reachability status metric value to 1 instead of 0#5368gacevicljubisa merged 1 commit intomasterfrom
gacevicljubisa merged 1 commit intomasterfrom
Conversation
gacevicljubisa
requested review from
acud,
akrem-chabchoub,
janos and
martinconic
akrem-chabchoub
approved these changes
Feb 15, 2026
janos
approved these changes
Feb 15, 2026
martinconic
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
The ReachabilityStatus gauge was always being set to 0 for all labels,
making the metric effectively useless. Reset all labels on status change
and set the current status to 1.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):