Skip to content

feat: wait for block persistence before stopping container#157

Open
skylenet wants to merge 1 commit intomasterfrom
reth-fixes
Open

feat: wait for block persistence before stopping container#157
skylenet wants to merge 1 commit intomasterfrom
reth-fixes

Conversation

@skylenet
Copy link
Copy Markdown
Member

Summary

  • Poll eth_blockNumber after pre-run steps to confirm the client has finished persisting blocks before stopping/checkpointing the container. This prevents data loss with clients like reth that persist blocks asynchronously.
  • Set explicit 30s graceful shutdown timeout on StopContainer for both Docker and Podman (was Docker default 10s / Podman unset).
  • Add log lines around container stop/checkpoint operations for better observability.

Test plan

  • Verify block persistence polling logs appear before container stop in ZFS snapshot flow
  • Verify block persistence polling logs appear before checkpoint in CRIU flow
  • Verify container stop uses 30s timeout (check Docker/Podman stop behavior)
  • Verify graceful degradation when eth_blockNumber RPC fails (should warn and proceed)

…s stop timeout

Poll eth_blockNumber after pre-run steps to confirm the client has
finished persisting blocks before stopping/checkpointing the container.
This prevents data loss with clients like reth that persist blocks
asynchronously. Also sets an explicit 30s graceful shutdown timeout on
StopContainer for both Docker and Podman.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant