feat: wait for block persistence before stopping container#157
Open
feat: wait for block persistence before stopping container#157
Conversation
…s stop timeout Poll eth_blockNumber after pre-run steps to confirm the client has finished persisting blocks before stopping/checkpointing the container. This prevents data loss with clients like reth that persist blocks asynchronously. Also sets an explicit 30s graceful shutdown timeout on StopContainer for both Docker and Podman.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eth_blockNumberafter pre-run steps to confirm the client has finished persisting blocks before stopping/checkpointing the container. This prevents data loss with clients like reth that persist blocks asynchronously.StopContainerfor both Docker and Podman (was Docker default 10s / Podman unset).Test plan
eth_blockNumberRPC fails (should warn and proceed)