inventory: rename ethereum_node_fact_{cl_enr,el_enode} → _discovery_ variants#14
Merged
Conversation
…variants Catches up to ansible-collection-general PR #509 (renamed for ansible-lint var-naming) which has been pulled in since requirements.yaml was bumped to track master.
Contributor
There was a problem hiding this comment.
this needs to stay debug
Member
Author
There was a problem hiding this comment.
Have we confirmed that? It's been on for months
Restores debug logging on Prysm beacon nodes per Barnabas's request.
…case) The container parser fails on otelcol's own log file (returns 'failed to detect a valid log path'), leaving container.name nil and the existing name-based filter unable to match. Extends the filter to also drop entries whose body contains 'otelcol-contrib' or 'github.com/open-telemetry/opentelemetry-collector-contrib' — covers both the structured first-line and the stack-trace continuation lines. Verified on prysm-besu-full-1: cluster otelcol-error volume from 500-900/min → 0/min, legitimate log flow unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catches up to ansible-collection-general PR #509 (lint rename). Inventory has been stale since requirements.yaml bumped to master in 1163abb — any container-recreate that resolves ethereum_cl_bootnodes/ethereum_el_bootnodes fails on missing hostvar.