otelcol: add full host-level log attributes (Loki parity)#18
Open
samcm wants to merge 1 commit into
Open
Conversation
Adds the host-level resource attributes the vector->Loki path carried to the otelcol logs pipeline: forwarder, instance, network, testnet, ingress_user, plus ethereum_cl / ethereum_el per host (where defined). Static filelog is kept for reliable collection of every container. Per-container container.name/image was attempted via docker_observer + receiver_creator but reverted: docker_observer is port-oriented, so it misses containers with no exposed ports (e.g. validator) and double-tails multi-port ones (e.g. beacon). Reliable per-container metadata needs the docker json-file `tag` log-opt instead, which applies on container recreation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the host-level resource attributes the vector→Loki path carried to the otelcol logs pipeline, so
external.otel_logsreaches parity with what Loki had (minus per-containercontainer_name, see below):forwarder,instance,testnet(alias ofnetwork), andethereum_cl/ethereum_elper host (where defined), on top of the existingnetwork,ingress_user,host.name,deployment.environment.Static
filelogis kept for reliable collection of every container.Verified live on
lighthouse-geth-super-1(otelcol-only rollout): all attributes land on every container's logs.Not included — per-container
container.name/image: attempted viadocker_observer+receiver_creator, but reverted becausedocker_observeris port-oriented — it misses containers with no published ports (e.g.validator) and double-tails multi-port ones (e.g.beacon). Reliable per-container metadata needs the Docker json-filetaglog-opt (embeds the name in each line'sattrsfor a static filelog to parse), which applies on container recreation — a separate change.