chore: pre-ship housekeeping sweep#114
Open
samcm wants to merge 1 commit into
Open
Conversation
Low-risk fixes from a multi-agent review of the whole stack: correctness, consistency, dead-code removal, comment hygiene, and config drift. - auth: fix data race in token-store refresh; serialize concurrent refreshes with a stdlib mutex (no double provider call); emit RFC 8628 slow_down on fast device polling; stop logging raw GitHub response bodies - sandbox: gVisor backend shares Docker's Start so it also reaps orphaned containers at startup; force-remove leaked session containers on first-exec failure; check the script-stage exec exit code; share env-var name constants across the execsvc/sandbox boundary - server: route /api/v1 operation errors through the JSON error helper - modules: align published Python signatures with the real functions; delete the dead module-config surface (Init rawConfig is always nil) - config: fix metrics_port to match docker-compose; strict-decode client config - de-duplicate the X-Datasource header constant; document proxy config keys; assorted dead-code, comment, and consistency cleanups; refresh stale docs Larger structural refactors and the datasource-selector unification are left to a follow-up PR that builds on this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies low-risk housekeeping fixes from a whole-stack review: a token-store data race fix with serialized refresh, gVisor startup orphan-cleanup parity with the Docker backend, JSON
/api/v1operation errors, Python signatures aligned to the real functions, and removal of the dead module-config surface. Also corrects themetrics_portvalue docker-compose forwards, de-duplicates theX-Datasourceconstant, and clears assorted dead code, stale comments, and config drift.