feat(vm): 8 opcode handler modules (4)#7
Open
haeter525 wants to merge 3 commits into
Open
Conversation
Fills in the held-back handler modules from the scaffold: arithmetic,
array, branch, compare, field, throw, type_check, type_conv. Re-enables
their imports and register() calls in engine.py so the VM can execute
every non-Android-stub-dependent opcode.
Verification (one-liner):
pytest tests/vm/test_arithmetic.py tests/vm/test_wide_arithmetic.py -q
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
haeter525
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fills in the handler modules with the following type of instructions:
arithmeticarraybranchcomparefieldthrowtype_checktype_convertSo the VM can execute every non-stub-dependent opcode end-to-end.
Scope
src/dextrace/vm/handlers/arithmetic,array,branch,compare,field,throw,type_check,type_conv)src/dextrace/vm/engine.pyregister()callstests/vm/test_{arithmetic,wide_arithmetic,handlers,type_check,throw_signal,trace,call_return}.py— handler unit tests + engine integrationtests/test_vm_run_*.pyarrays,fibonacci,inheritance,instance_fields,interface_dispatch,long_arithmetic,packed_switch,try_catch,try_catch_with_fields— end-to-end execution teststools/gen_*_fixture.pytests/conftest.pyat session start; the generated.dexfiles are gitignored)One-line verification
Full suite:
pytest -q # 314 passed