refactor: remove blanket clippy::unwrap_used allows

crates/bashkit/src/builtins/archive.rs

@@ -905,7 +905,6 @@ impl Builtin for Gunzip {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/assert.rs

@@ -181,7 +181,6 @@ impl Builtin for Assert {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/awk.rs

@@ -3126,7 +3126,6 @@ impl Awk {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use crate::fs::{FileSystem, InMemoryFs};

crates/bashkit/src/builtins/bc.rs

@@ -498,7 +498,6 @@ impl<'a> ExprParser<'a> {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/checksum.rs

@@ -82,7 +82,6 @@ fn hex_digest<D: Digest>(data: &[u8]) -> String {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/column.rs

@@ -195,7 +195,6 @@ impl Builtin for Column {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/comm.rs

@@ -174,7 +174,6 @@ impl Builtin for Comm {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/compgen.rs

@@ -195,7 +195,6 @@ impl Builtin for Compgen {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/csv.rs

@@ -381,7 +381,6 @@ impl Builtin for Csv {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/curl.rs

@@ -1009,7 +1009,6 @@ fn extract_host_from_url(url: &str) -> String {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/cuttr.rs

@@ -530,7 +530,6 @@ fn expand_char_set(spec: &str) -> Vec<char> {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/date.rs

@@ -428,7 +428,6 @@ impl Builtin for Date {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/diff.rs

@@ -294,7 +294,6 @@ impl Builtin for Diff {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/dirstack.rs

@@ -221,7 +221,6 @@ fn format_stack(ctx: &Context<'_>) -> String {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/disk.rs

@@ -250,7 +250,6 @@ impl Builtin for Df {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use crate::fs::{FileSystem, FsLimits, InMemoryFs};

crates/bashkit/src/builtins/dotenv.rs

@@ -157,7 +157,6 @@ impl Builtin for Dotenv {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/echo.rs

@@ -71,8 +71,6 @@ impl Builtin for Echo {
     }
 }
 
-// to_digit().unwrap() is safe: only called after is_ascii_hexdigit() check
-#[allow(clippy::unwrap_used)]
 fn interpret_escape_sequences(s: &str) -> String {
     let mut result = String::new();
     let mut chars = s.chars().peekable();
@@ -109,7 +107,10 @@ fn interpret_escape_sequences(s: &str) -> String {
                     for _ in 0..2 {
                         if let Some(&digit) = chars.peek() {
                             if digit.is_ascii_hexdigit() {
-                                value = value * 16 + digit.to_digit(16).unwrap() as u8;
+                                value = value * 16
+                                    + digit.to_digit(16).expect(
+                                        "to_digit(16) valid: guarded by is_ascii_hexdigit()",
+                                    ) as u8;
                                 chars.next();
                             } else {
                                 break;
@@ -137,7 +138,6 @@ fn interpret_escape_sequences(s: &str) -> String {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
 

crates/bashkit/src/builtins/environ.rs

@@ -168,7 +168,6 @@ impl Builtin for History {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/expand.rs

@@ -239,7 +239,6 @@ fn next_tab_stop(col: usize, tab_stops: &[usize]) -> usize {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use crate::fs::InMemoryFs;

crates/bashkit/src/builtins/expr.rs

@@ -254,7 +254,6 @@ fn char_matches(c: char, pattern: char) -> bool {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/fc.rs

@@ -153,7 +153,6 @@ impl Builtin for Fc {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/fileops.rs

@@ -150,8 +150,6 @@ pub struct Cp;
 
 #[async_trait]
 impl Builtin for Cp {
-    // files.last().unwrap() is safe: guarded by files.len() < 2 check above
-    #[allow(clippy::unwrap_used)]
     async fn execute(&self, ctx: Context<'_>) -> Result<ExecResult> {
         if ctx.args.len() < 2 {
             return Ok(ExecResult::err("cp: missing file operand\n".to_string(), 1));
@@ -167,7 +165,9 @@ impl Builtin for Cp {
             ));
         }
 
-        let dest = files.last().unwrap();
+        let dest = files
+            .last()
+            .expect("files.last() valid: guarded by files.len() < 2 check above");
         let sources = &files[..files.len() - 1];
         let dest_path = resolve_path(ctx.cwd, dest);
 
@@ -218,8 +218,6 @@ pub struct Mv;
 
 #[async_trait]
 impl Builtin for Mv {
-    // files.last().unwrap() is safe: guarded by files.len() < 2 check above
-    #[allow(clippy::unwrap_used)]
     async fn execute(&self, ctx: Context<'_>) -> Result<ExecResult> {
         if ctx.args.len() < 2 {
             return Ok(ExecResult::err("mv: missing file operand\n".to_string(), 1));
@@ -234,7 +232,9 @@ impl Builtin for Mv {
             ));
         }
 
-        let dest = files.last().unwrap();
+        let dest = files
+            .last()
+            .expect("files.last() valid: guarded by files.len() < 2 check above");
         let sources = &files[..files.len() - 1];
         let dest_path = resolve_path(ctx.cwd, dest);
 
@@ -426,8 +426,6 @@ fn apply_symbolic_mode(mode_str: &str, current_mode: u32) -> Option<u32> {
 
 #[async_trait]
 impl Builtin for Chmod {
-    // from_str_radix().unwrap() is safe: is_ok() check on same value above
-    #[allow(clippy::unwrap_used)]
     async fn execute(&self, ctx: Context<'_>) -> Result<ExecResult> {
         if ctx.args.len() < 2 {
             return Ok(ExecResult::err("chmod: missing operand\n".to_string(), 1));
@@ -453,7 +451,8 @@ impl Builtin for Chmod {
             }
 
             let mode = if is_octal {
-                u32::from_str_radix(mode_str, 8).unwrap()
+                u32::from_str_radix(mode_str, 8)
+                    .expect("from_str_radix valid: is_octal confirmed by is_ok() check above")
             } else {
                 // Symbolic mode - need current permissions
                 let current_mode = match ctx.fs.stat(&path).await {
@@ -735,7 +734,6 @@ impl Builtin for Mktemp {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/flow.rs

@@ -115,7 +115,6 @@ impl Builtin for Return {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/fold.rs

@@ -135,7 +135,6 @@ fn fold_line(line: &str, width: usize, break_at_spaces: bool, output: &mut Strin
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use crate::fs::InMemoryFs;

crates/bashkit/src/builtins/glob_cmd.rs

@@ -150,7 +150,6 @@ impl GlobCmd {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/grep.rs

@@ -786,7 +786,6 @@ impl Builtin for Grep {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use crate::fs::{FileSystem, InMemoryFs};

crates/bashkit/src/builtins/headtail.rs

@@ -287,7 +287,6 @@ fn take_last_lines(text: &str, n: usize) -> String {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/help.rs

@@ -506,7 +506,6 @@ impl Builtin for Help {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/hextools.rs

@@ -550,7 +550,6 @@ async fn collect_input(
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/http.rs

@@ -434,7 +434,6 @@ async fn execute_http_request(
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/iconv.rs

@@ -291,7 +291,6 @@ impl Builtin for Iconv {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/inspect.rs

@@ -400,7 +400,6 @@ fn default_stat_format(name: &str, metadata: &crate::fs::Metadata) -> String {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/join.rs

@@ -160,7 +160,6 @@ async fn read_input(
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use crate::fs::{FileSystem, InMemoryFs};

crates/bashkit/src/builtins/jq.rs

@@ -568,7 +568,6 @@ impl Builtin for Jq {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use crate::fs::{FileSystem, InMemoryFs};

crates/bashkit/src/builtins/json.rs

@@ -301,7 +301,6 @@ impl Builtin for Json {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/log.rs

@@ -143,7 +143,6 @@ impl Builtin for Log {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/ls.rs

@@ -930,7 +930,6 @@ impl Builtin for Rmdir {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/mkfifo.rs

@@ -115,7 +115,6 @@ impl Builtin for Mkfifo {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use crate::fs::{FileSystem, InMemoryFs};

crates/bashkit/src/builtins/nl.rs

@@ -228,7 +228,6 @@ impl Builtin for Nl {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;

crates/bashkit/src/builtins/parallel.rs

@@ -227,7 +227,6 @@ impl Builtin for Parallel {
 }
 
 #[cfg(test)]
-#[allow(clippy::unwrap_used)]
 mod tests {
     use super::*;
     use std::collections::HashMap;