cleanup tests

[tac0turtle]

Overview

this pr removes redundant tests

Summary by CodeRabbit

• Tests
  • Removed test cases validating default configurations, health status data, namespace conversions, metrics behavior, key formatting, empty blob operations, and synchronization state persistence.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a981179 and fc90d26.

📒 Files selected for processing (7)

• config/load_test.go
• pkg/api/health_test.go
• pkg/fetch/celestia_node_test.go
• pkg/metrics/metrics_test.go
• pkg/store/s3_test.go
• pkg/store/sqlite_test.go
• pkg/sync/backfill_test.go

💤 Files with no reviewable changes (7)

• pkg/metrics/metrics_test.go
• config/load_test.go
• pkg/store/sqlite_test.go
• pkg/store/s3_test.go
• pkg/api/health_test.go
• pkg/sync/backfill_test.go
• pkg/fetch/celestia_node_test.go

---

📝 Walkthrough

Walkthrough

Multiple test files have test functions and assertions removed, including TestDefaultConfigDefaults, TestHealthEndpoint validations, TestNamespacesToBytes, TestNopRecorderDoesNotPanic, TestS3Store_PrefixAndKeyFormat, TestS3Store_EmptyPutBlobs, TestPutBlobsEmpty, and BatchProcessing subtests. A single unused import (encoding/hex) is also removed.

Changes

Cohort / File(s)	Summary
Config Tests config/load_test.go	Removed TestDefaultConfigDefaults test function that validated default values for Profiling, Sync, RPC, and Subscription config fields.
API & Health Tests pkg/api/health_test.go	Removed SyncLag field assertion from TestHealthEndpoint, now only validates Healthy field and status code.
Fetch Tests pkg/fetch/celestia_node_test.go	Removed TestNamespacesToBytes test function.
Metrics Tests pkg/metrics/metrics_test.go	Removed TestNopRecorderDoesNotPanic test function.
Store Tests pkg/store/s3_test.go	Removed encoding/hex import and deleted TestS3Store_PrefixAndKeyFormat and TestS3Store_EmptyPutBlobs test functions.
Store Tests pkg/store/sqlite_test.go	Removed TestPutBlobsEmpty test function that exercised PutBlobs with nil and empty slices.
Sync Tests pkg/sync/backfill_test.go	Removed post-run validations for blob count and SyncState LatestHeight, and deleted the SingleHeight subtest from BatchProcessing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 With a hop and a skip, the tests take flight,
Removed from the suite to keep things tight,
No more assertions cluttering the way,
Just cleaner code to brighten the day! 🧹✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'cleanup tests' is vague and generic, using non-descriptive language that doesn't convey meaningful information about the specific changes beyond a general cleanup theme.	Consider using a more specific title such as 'Remove redundant tests across multiple packages' or 'Clean up unnecessary test cases' to better reflect the scope and nature of the changes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch marko/test_cleanup

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}