feat(playground): overlay the editor at boot instead of baking it in#47
Merged
Conversation
The playground preview zip no longer bundles the ~73MB eXeLearning editor. Instead the blueprint installs the lean app and overlays the upstream editor release at boot via the new `unzip` step (mirroring the Moodle/WP playgrounds), keeping the preview zip small and the editor a shared upstream artifact. - blueprint.json: add an `unzip` step that extracts the upstream editor into the installed app's js/editor/ (strips the 'static/' wrapper), pinned to .editor-version. - playground-preview.yml: drop the `make download-editor` step so package-zip ships without js/editor/; report the overlaid editor version from .editor-version. - auto-release.yml: keep the blueprint's editor URL in sync with .editor-version on each bump (sed, committed with the marker). Production (release.yml / auto-release.yml) still bakes the editor into the appstore tarball — EditorController serves it disk-only with no runtime download.
Contributor
Preview this PR in the Nextcloud Playground
A fresh Nextcloud boots in your browser with this branch's eXeLearning editor: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The playground preview no longer bakes the ~73 MB eXeLearning editor into the app zip. The blueprint installs the lean app and overlays the upstream editor release at boot via the new
unzipstep — mirroring the Moodle/WP playgrounds.Why
Consistency with the other eXeLearning playgrounds (the editor is a shared upstream artifact, overlaid at boot) and a much smaller preview zip.
How
blueprint.json: add anunzipstep that extracts the upstream editor into the installed app'sjs/editor/(strips thestatic/wrapper), pinned to.editor-version..github/workflows/playground-preview.yml: drop themake download-editorstep sopackage-zipships withoutjs/editor/; report the overlaid editor version from.editor-versionin the PR comment..github/workflows/auto-release.yml: keep the blueprint's editor URL in sync with.editor-versionon each bump (sed, committed with the marker) — the same durable pattern as the Moodle/WP plugins.Scope: playground only
Production (
release.yml/auto-release.yml) still bakes the editor into the appstore tarball —EditorControllerserves it disk-only (EditorController.php:54,221-223) with no runtime download, and an appstore app must be self-contained. This change touches the playground preview only;make download-editor/build-editorstay for production and local Docker.Depends on
ateeducacion/nextcloud-playground#21 (the new
unzipblueprint step). That must merge and deploy first, otherwise the deployed playground does not recognize theunzipstep and the editor would not be overlaid.