fix(playground): use github-proxy.exelearning.dev for installApp#49
Merged
Conversation
The installApp step and the per-PR preview link still pointed at zip-proxy.erseco.workers.dev, which is no longer reachable (the host fails the TLS handshake), so the playground's cross-origin fetch of the app ZIP died with "Failed to fetch" and the critical blueprint step aborted before the app was installed/enabled. Point both at github-proxy.exelearning.dev, the project's own CORS proxy already used by the editor unzip step. Same GitHub-mode query interface (?repo=&release=&asset=), verified to serve exelearning.zip with Access-Control-Allow-Origin: *.
Contributor
Preview this PR in the Nextcloud Playground
A fresh Nextcloud boots in your browser with this branch's eXeLearning editor: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The eXeLearning app does not load in the Nextcloud Playground. During bootstrap:
Cause
The
installAppstep (and the per-PR preview link in the workflow) downloaded the app ZIP through and outdated url, which is no longer reachable: that host fails the TLS handshake (it answers with an nginx serving a self-signedcore1.netops.testcert), so the playground's cross-originfetchdies withFailed to fetchand the critical step aborts before the app is installed/enabled. The editor still loaded because theunzipstep already usesgithub-proxy.exelearning.dev.Change
Point both references at
github-proxy.exelearning.dev(the project's own CORS proxy, same?repo=&release=&asset=interface):blueprint.json—installAppstep (fixes the live preview, which reads the blueprint frommain)..github/workflows/playground-preview.yml— per-PR preview link.Verified:
GET github-proxy.exelearning.dev/?repo=exelearning/nextcloud-exelearning&release=playground&asset=exelearning.zip→ HTTP 200,content-length: 652354(= the release asset),access-control-allow-origin: *.Verification after merge
Reload the playground preview: the log should show
Downloading app: exelearningwithoutStep "installApp" failed, the app ends up enabled, and the sample.elpxfiles open in the editor.