Skip to content

Fix bad flag ref in dns add NS#812

Merged
kobajagi merged 2 commits intomasterfrom
predrag/sc-150195/gh-issue-cli-bug-cli-fails-when-adding-ns-record
Mar 23, 2026
Merged

Fix bad flag ref in dns add NS#812
kobajagi merged 2 commits intomasterfrom
predrag/sc-150195/gh-issue-cli-bug-cli-fails-when-adding-ns-record

Conversation

@kobajagi
Copy link
Contributor

@kobajagi kobajagi commented Mar 23, 2026

Description

Fixes #759

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block, and add the Pull Request #number for each bit you add to the CHANGELOG.md)
  • Testing

Testing

> go run . dns add NS external-dns-test.jns.vc -n tmp -s ns1.exoscale.ch
 ✔ Adding DNS record "NS" to "external-dns-test.jns.vc"... 0s
Record "NS" was created successfully to "external-dns-test.jns.vc"

Copy link
Member

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, pflag strikes again... 😅

@kobajagi Is there a reason why the dns commands aren't using the cliCommand abstraction as other commands? It seems that it would give us type safety that would avoid these string lookup issues.

@kobajagi
Copy link
Contributor Author

Ah, pflag strikes again... 😅

@kobajagi Is there a reason why the dns commands aren't using the cliCommand abstraction as other commands? It seems that it would give us type safety that would avoid these string lookup issues.

Code i fixed was last changed in 2018, context is lost in history 🤷‍♂️
My PR fixes specific bug, but yes we should bring the DNS codebase up to standards (separate from bug fix).

@kobajagi kobajagi merged commit d090d4f into master Mar 23, 2026
5 checks passed
@kobajagi kobajagi deleted the predrag/sc-150195/gh-issue-cli-bug-cli-fails-when-adding-ns-record branch March 23, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CLI Fails When Adding NS Record with exo dns add NS

4 participants