Fix #6462: Log full error object instead of just stack in logerror#7094
Closed
NithikYekollu wants to merge 1 commit into
Closed
Fix #6462: Log full error object instead of just stack in logerror#7094NithikYekollu wants to merge 1 commit into
NithikYekollu wants to merge 1 commit into
Conversation
Change console.error(err.stack || err.toString()) to console.error(err) so that error details like Error.cause and custom properties (e.g. Sequelize parent/original) are preserved in the output. Fixes expressjs#6462 Co-Authored-By: nithik <nithik@berkeley.edu>
Open
4 tasks
Contributor
|
Duplicate of #6464 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
logerrorinlib/application.jsto useconsole.error(err)instead ofconsole.error(err.stack || err.toString()), so that error details likeError.causeand custom properties (e.g. Sequelizeparent/original) are preserved in the console output.Fixes #6462
Changes
console.error(err.stack || err.toString())toconsole.error(err)in thelogerrorfunctionWhy
console.error(err)delegates to Node's built-in error inspection, which handlesError.cause, custom enumerable properties, and other details thaterr.stackalone discards.The
testenvironment guard (this.get('env') !== 'test') is unchanged.Link to Devin Session: https://app.devin.ai/sessions/68fe83d5d3064681931d4a9d7cdd7238
Requested by: nithik (nithik@berkeley.edu) / @NithikYekollu