Log error objects in the default error handler#7288
Closed
Subharup-31 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Duplicate of #6464 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The default Express final-handler logger currently logs
err.stack || err.toString(). That stringifies the error too early and can hide structured error details such asError.causeor additional properties provided by libraries.Root cause
logerrorextracts the stack string before passing the error toconsole.error, so Node's object/error formatter cannot include nested details.Fix
Pass the error object directly to
console.error. This preserves existing stack output while allowing runtimes to include richer error object information.Testing
git diff --checksuccessfully.Fixes #6462