(Chore) Update node-sass-middleware to v1.0.1#309
Open
p4nu wants to merge 4 commits intoexpressjs:masterfrom
Open
(Chore) Update node-sass-middleware to v1.0.1#309p4nu wants to merge 4 commits intoexpressjs:masterfrom
p4nu wants to merge 4 commits intoexpressjs:masterfrom
Conversation
This closes issues: Running tests locally fails expressjs#308 and Sass Generator not working out of the box expressjs#296
Contributor
Author
|
I'll update changes to be backwards compatible with older nodejs versions. |
for node-sass-middleware dependency. Update node-sass-middleware to version >= 1 when nodejs version is >= 10. This should fix the errors with earlier node versions to pass the tests.
for nodejs version testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will enable local tests to be run in newer nodejs versions. This will also fix the Sass Generator not working out of the box in newer nodejs versions.
Closes #308
Closes #296
This will also help #303 to pass tests