fix: update default view engine from jade to pug#328
fix: update default view engine from jade to pug#328RushilJalal wants to merge 1 commit intoexpressjs:masterfrom
Conversation
|
@UlisesGascon @IamLizu The checks are failing. I require some assistance on how to fix this... |
|
From what I can see: It seems like
|
|
So what is the next step? Do I need to make any changes? |
IamLizu
left a comment
IamLizu
left a comment
There was a problem hiding this comment.
we can include this change in the next major release or upgrade to a version of pug that remains compatible with the Node.js versions we currently support.
I think you should do the latter.
| @@ -467,7 +467,7 @@ function main (options, done) { | |||
| if (options.view === true) { | |||
| warning('the default view engine will not be jade in future releases\n' + | |||
There was a problem hiding this comment.
Unnecessary warning if jage is no longer the default.
There was a problem hiding this comment.
Should I remove this warning completely?
| ' "jade": "~1.11.0",\n' + | ||
| // replace default jade with pug | ||
| // ' "jade": "~1.11.0",\n' + | ||
| ' "pug": "~3.0.3",\n' + |
There was a problem hiding this comment.
Why is the latest version of pug incompatible? Which version should it be instead?
3 participants
fixes #327