Inject disabled parameters in Adapter instead of in GenNode (recently this was done all the way in input constructors...) (#5091)#5091
Closed
lena-kashtelyan wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@lena-kashtelyan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89779057. |
meta-codesync
bot
changed the title
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Mar 23, 2026
… this was done all the way in input constructors...) (facebook#5091) Summary: NOTE: alternative discussed here: https://www.internalfb.com/diff/D80175141?dst_version_fbid=702192172774838&transaction_fbid=1405256097977865 –– let's decide what do Differential Revision: D89779057
lena-kashtelyan
force-pushed
the
export-D89779057
branch
from
bd1406c to
b0cfb65
Compare
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Mar 23, 2026
… this was done all the way in input constructors...) (facebook#5091) Summary: Pull Request resolved: facebook#5091 NOTE: alternative discussed here: https://www.internalfb.com/diff/D80175141?dst_version_fbid=702192172774838&transaction_fbid=1405256097977865 –– let's decide what do Differential Revision: D89779057
lena-kashtelyan
force-pushed
the
export-D89779057
branch
from
b0cfb65 to
dec95d0
Compare
lena-kashtelyan
force-pushed
the
export-D89779057
branch
from
dec95d0 to
4c3f9f3
Compare
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Mar 31, 2026
… this was done all the way in input constructors...) (facebook#5091) Summary: NOTE: alternative discussed here: https://www.internalfb.com/diff/D80175141?dst_version_fbid=702192172774838&transaction_fbid=1405256097977865 –– let's decide what do Reviewed By: saitcakmak Differential Revision: D89779057
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Mar 31, 2026
… this was done all the way in input constructors...) (facebook#5091) Summary: NOTE: alternative discussed here: https://www.internalfb.com/diff/D80175141?dst_version_fbid=702192172774838&transaction_fbid=1405256097977865 –– let's decide what do Reviewed By: saitcakmak Differential Revision: D89779057
lena-kashtelyan
force-pushed
the
export-D89779057
branch
from
4c3f9f3 to
2ec249e
Compare
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Mar 31, 2026
… this was done all the way in input constructors...) (facebook#5091) Summary: Pull Request resolved: facebook#5091 NOTE: alternative discussed here: https://www.internalfb.com/diff/D80175141?dst_version_fbid=702192172774838&transaction_fbid=1405256097977865 –– let's decide what do Reviewed By: saitcakmak Differential Revision: D89779057
lena-kashtelyan
force-pushed
the
export-D89779057
branch
from
2ec249e to
a467e04
Compare
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Mar 31, 2026
… this was done all the way in input constructors...) (facebook#5091) Summary: Pull Request resolved: facebook#5091 NOTE: alternative discussed here: https://www.internalfb.com/diff/D80175141?dst_version_fbid=702192172774838&transaction_fbid=1405256097977865 –– let's decide what do Reviewed By: saitcakmak Differential Revision: D89779057
lena-kashtelyan
force-pushed
the
export-D89779057
branch
from
a467e04 to
8df96dc
Compare
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Apr 2, 2026
… this was done all the way in input constructors...) (facebook#5091) Summary: NOTE: alternative discussed here: https://www.internalfb.com/diff/D80175141?dst_version_fbid=702192172774838&transaction_fbid=1405256097977865 –– let's decide what do Reviewed By: saitcakmak Differential Revision: D89779057
lena-kashtelyan
force-pushed
the
export-D89779057
branch
from
8df96dc to
ae71a34
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5091 +/- ##
==========================================
- Coverage 96.40% 96.40% -0.01%
==========================================
Files 613 613
Lines 68171 68187 +16
==========================================
+ Hits 65721 65736 +15
- Misses 2450 2451 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… this was done all the way in input constructors...) (facebook#5091) Summary: NOTE: alternative discussed here: https://www.internalfb.com/diff/D80175141?dst_version_fbid=702192172774838&transaction_fbid=1405256097977865 –– let's decide what do Reviewed By: saitcakmak Differential Revision: D89779057
lena-kashtelyan
force-pushed
the
export-D89779057
branch
from
ae71a34 to
72c970c
Compare
|
This pull request has been merged in c8a547d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
NOTE: alternative discussed here: https://www.internalfb.com/diff/D80175141?dst_version_fbid=702192172774838&transaction_fbid=1405256097977865 –– let's decide what do
Reviewed By: saitcakmak
Differential Revision: D89779057