fix(theme-classic): support nested elements inside inline code#12164
Open
MasterIfeanyi wants to merge 1 commit into
Open
fix(theme-classic): support nested elements inside inline code#12164MasterIfeanyi wants to merge 1 commit into
MasterIfeanyi wants to merge 1 commit into
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
When using CommonMark format, wrapping inline content that contains nested HTML elements (like
<var>) inside a<code>tag incorrectly renders as a block code element instead of inline code.For example,
<code>inline <var>var</var></code>was being rendered as a<pre>block instead of staying inline.This fixes #10533.
Test Plan
The
shouldBeInlinefunction inMDXComponents/Code.tsxpreviously only treated plain strings as inline-safe. This PR introduces acontainsNewlinehelper that recursively checks nested React elements for newlines, so elements like<var>inside<code>are correctly treated as inline as long as they contain no newlines.To verify: add
This is <code>inline <var>var</var></code>to any Markdown file with CommonMark enabled and confirm it renders inline instead of as a code block.Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs
Closes #10533