fix(theme): use native dialog element for mobile sidebar#12165
Open
MasterIfeanyi wants to merge 1 commit into
Open
fix(theme): use native dialog element for mobile sidebar#12165MasterIfeanyi wants to merge 1 commit into
MasterIfeanyi wants to merge 1 commit into
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
The mobile sidebar looks like a modal dialog visually, but it was not behaving like one for assistive technologies. Screen reader users could tab outside the dialog while it was open, focus was not trapped inside, and the dialog role was not exposed to the accessibility tree.
This replaces the outer
<div>with a native HTML<dialog>element usingshowModal(), which gives us focus trapping, correct dialog role in the accessibility tree, Escape key handling, and return focus to the trigger element — all for free from the browser.Closes #9457.
Test Plan
On a mobile viewport or by zooming in on desktop:
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs
Closes #9457
Related to #10706 (previous attempt at this fix)