Ban subclassing dataclasses with order=True#3804
Open
ak4-sh wants to merge 2 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Feat: add stlib origin flag in Dataclass Metadata Feat: only raise inheritance warning when subclassing ordered dataclass Add tests to confirm ordered dataclass behaviour Update docs with new errorkind
ak4-sh
force-pushed
the
ban-order-dataclass-subclassing
branch
from
82ea78a to
5b3c20f
Compare
Author
|
@yangdanny97 Made the changes we discussed! Please let me know if all looks okay |
ak4-sh
force-pushed
the
ban-order-dataclass-subclassing
branch
from
7e1ea88 to
08f1344
Compare
Contributor
|
@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this in D109264971. |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
reconcile latest master changes with branch run cargo fmt
ak4-sh
force-pushed
the
ban-order-dataclass-subclassing
branch
from
08f1344 to
a73dbf6
Compare
Author
|
I think linter was failing to due to me not running cargo fmt after some previous changes, I've run the fmt and pushed changes. Should be good now hopefully. Sorry about this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
invalid-inheritanceerror when a class subclasses a dataclass that hasorder=True.Fixes #3762
Test Plan
Added test
test_parent_dataclass_with_orderto confirm behaviour