TextLayoutUtils: Use named arguments#42593
Closed
jakub-trzebiatowski wants to merge 1 commit intofacebook:mainfrom
Closed
TextLayoutUtils: Use named arguments#42593jakub-trzebiatowski wants to merge 1 commit intofacebook:mainfrom
TextLayoutUtils: Use named arguments#42593jakub-trzebiatowski wants to merge 1 commit intofacebook:mainfrom
Conversation
...to ensure same-type arguments (like `start`/`end`) are not confused
facebook-github-bot
added
CLA Signed
Base commit: 6d77d7b |
mdvacca
approved these changes
Jan 24, 2024
Contributor
|
@mdvacca has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
TextLayoutUtils: Use named arguments to ensure same-type arguments (likestart/end) are not confusedThis is a minor readability follow-up to #39630.
Changelog:
[INTERNAL] [CHANGED] - Increase the
TextLayoutUtilsreadability slightlyTest Plan: