feat: Add mixBlendMode add-lighter#56278
Open
bigcupcoffee wants to merge 2 commits intofacebook:mainfrom
Open
Conversation
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds missing
mixBlendMode: 'plus-lighter'which has full support on CSS across all browsers (as opposed to, for example,plus-darker)iOS: ended up using linear dodge blend mode which should be identical, I tried using
@"addition"which should've usedCIAdditionCompositingbut that didn't work, although I did confirmmaximumdoes work and applyCIMaximumCompositing, funny stuff, can't wait for SwiftUI layer to take this overAndroid works as expected with its
BlendMode.PLUSChangelog:
[GENERAL] [ADDED] - Add mixBlendMode plus-lighter
Test Plan: