Add React-Core-prebuilt and ReactNativeDependencies to pod update command#56297
Open
alanleedev wants to merge 1 commit intofacebook:mainfrom
Open
Add React-Core-prebuilt and ReactNativeDependencies to pod update command#56297alanleedev wants to merge 1 commit intofacebook:mainfrom
alanleedev wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@alanleedev has exported this pull request. If you are a Meta employee, you can view the originating Diff in D98989657. |
…mand Summary: React-Core-prebuilt and ReactNativeDependencies both read their version from package.json. When the version is bumped on a stable branch, the checked-in Podfile.lock becomes stale for these pods, causing CI to fail with a CocoaPods version mismatch. Adding them to the pod update command resolves this at runtime. These pods are only present when use-frameworks is false (the prebuilt path), so the update is conditional to avoid 'not installed' errors in the dynamic frameworks CI configuration. Differential Revision: D98989657
alanleedev
force-pushed
the
export-D98989657
branch
from
e4064d0 to
f017b18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
React-Core-prebuilt and ReactNativeDependencies both read their version from package.json. When the version is bumped on a stable branch, the checked-in Podfile.lock becomes stale for these pods, causing CI to fail with a CocoaPods version mismatch. Adding them to the pod update command resolves this at runtime.
These pods are only present when use-frameworks is false (the prebuilt path), so the update is conditional to avoid 'not installed' errors in the dynamic frameworks CI configuration.
Differential Revision: D98989657