[Bugfix] Don't double invoke effects for list reorders #35952
Open
rickhanlonii wants to merge 2 commits intofacebook:mainfrom
Open
[Bugfix] Don't double invoke effects for list reorders #35952rickhanlonii wants to merge 2 commits intofacebook:mainfrom
rickhanlonii wants to merge 2 commits intofacebook:mainfrom
Conversation
In placeChild, the move case was setting PlacementDEV in addition to Placement. PlacementDEV is meant to identify newly inserted fibers so that StrictMode can double-invoke their effects on mount. Moved fibers are not new insertions, so they should not have PlacementDEV set. This matches the behavior of placeSingleChild, which only sets PlacementDEV when alternate === null (i.e., a true insertion).
Add two tests that verify the StrictMode PlacementDEV fix handles mixed scenarios correctly: - Move + new mount: only the new item's effects are double-invoked - Move + removal: only the removed item's cleanup effects fire
github-actions
bot
added
the
React Core Team
|
Comparing: 4cc5b7a...e05c062 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32561