[Fiber] Double invoke Effects in Strict Mode during Hydration#35961
Open
eps1lon wants to merge 2 commits intofacebook:mainfrom
Open
[Fiber] Double invoke Effects in Strict Mode during Hydration#35961eps1lon wants to merge 2 commits intofacebook:mainfrom
eps1lon wants to merge 2 commits intofacebook:mainfrom
Conversation
github-actions
bot
added
the
React Core Team
|
Comparing: 93882bd...8975211 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
force-pushed
the
sebbie/se-hydration
branch
2 times, most recently
from
64740e0 to
be46b22
Compare
eps1lon
force-pushed
the
sebbie/se-hydration
branch
from
be46b22 to
8975211
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Also reported in vercel/next.js#66210
Not double invoking during Hydration was on oversight. Double invoking during Hydration ensures parity between
hydrateRootandcreateRoot.Double invoking an Effect is tracked with
PlacementDEV. This was always used together withPlacement. However, during hydration we don't track side-effects i.e. set noPlacementflag causing no double invocation of Effects in Strict Mode.Now we set
PlacementDEVwhen we set theHydrationflag to double invoke Effects in Strict Mode when we hydrated which is conceptually like a Placement during client-render.How did you test this change?