[compiler] Fix custom hook with use() not being compiled#35964
Open
carlbergman wants to merge 2 commits intofacebook:mainfrom
Open
[compiler] Fix custom hook with use() not being compiled#35964carlbergman wants to merge 2 commits intofacebook:mainfrom
carlbergman wants to merge 2 commits intofacebook:mainfrom
Conversation
Custom hooks whose only invocation is the `use()` function are skipped by the compiler. This fixture demonstrates the current (broken) output where `useMyContext` is not compiled. Ref facebook#35960
The `isHookName` check in Program.ts used the regex `/^use[A-Z0-9]/` which doesn't match `use()`. This caused custom hooks whose only invocation is `use()` to be skipped in infer mode. Fixes facebook#35960
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix detection of
use()in custom hooks for infer mode. TheisHookNamecheck used the regex/^use[A-Z0-9]/which doesn't matchuse. This caused custom hooks whose only invocation isuse()to be skipped in infer mode.This is the second PR per the development guide. The first PR is #35963.
Fixes #35960
How did you test this change?
yarn snap