Add the iframe credentialless prop#35967
Open
jamesbvaughan wants to merge 1 commit intofacebook:mainfrom
Open
Conversation
|
Comparing: 4610359...5901780 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for the iframe
credentiallessattribute. This is a (currently experimental) attribute that is useful for running iframes in pages using cross-origin isolation.https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/IFrame_credentialless
The current workaround in React projects is to use
credentialless=""(plus a// @ts-expect-errorcomment if you're using TypeScript).How did you test this change?
I updated the automated tests and ran them. I'm having trouble with my local React build so I haven't yet been able to test this with my project, but I'll update this PR description once I have.