Skip to content

Fix typos in comments #36487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
parkhojeong wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix typos in comments #36487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbd2d1c
Fix typo: propogate -> propagate
parkhojeong May 18, 2026
b27402f
Fix typo: preceeding -> preceding
parkhojeong May 18, 2026
e9b2ffd
Fix typo: overriden -> overridden
parkhojeong May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions compiler/packages/babel-plugin-react-compiler/src/Optimization/ConstantPropagation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ function evaluatePhi(phi: Phi, constants: Constants): Constant | null {
let value: Constant | null = null;
for (const [, operand] of phi.operands) {
const operandValue = constants.get(operand.identifier.id) ?? null;
// did not find a constant, can't constant propogate
// did not find a constant, can't constant propagate
if (operandValue === null) {
return null;
}
Expand All @@ -183,7 +183,7 @@ function evaluatePhi(phi: Phi, constants: Constants): Constant | null {
continue;
}

// found different kinds of constants, can't constant propogate
// found different kinds of constants, can't constant propagate
if (operandValue.kind !== value.kind) {
return null;
}
Expand All @@ -195,7 +195,7 @@ function evaluatePhi(phi: Phi, constants: Constants): Constant | null {
loc: GeneratedSource,
});

// different constant values, can't constant propogate
// different constant values, can't constant propagate
if (operandValue.value !== value.value) {
return null;
}
Expand All @@ -207,7 +207,7 @@ function evaluatePhi(phi: Phi, constants: Constants): Constant | null {
loc: GeneratedSource,
});

// different global values, can't constant propogate
// different global values, can't constant propagate
if (operandValue.binding.name !== value.binding.name) {
return null;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-client/src/ReactFlightClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5258,7 +5258,7 @@ export function processStringChunk(
// We found the last chunk of the row
if (buffer.length > 0) {
// If we had a buffer already, it means that this chunk was split up into
// binary chunks preceeding it.
// binary chunks preceding it.
throw new Error(
'String chunks need to be passed in their original shape. ' +
'Not split into smaller string chunks. ' +
Expand Down
2 changes: 1 addition & 1 deletion packages/react-reconciler/src/__tests__/ReactSuspenseWithNoopRenderer-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {
);

// Unblock the low-pri text and finish. Nothing in the UI changes because
// the update was overriden
// the update was overridden
await act(() => resolveText('2'));
assertLog(['2']);
expect(ReactNoop).toMatchRenderedOutput(
Expand Down
2 changes: 1 addition & 1 deletion packages/react-server/src/ReactFlightAsyncSequence.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export type IONode = {
end: number, // we typically don't use this. only when there's no promise intermediate.
promise: null, // not used on I/O
awaited: null, // I/O is only blocked on external.
previous: null | AwaitNode | UnresolvedAwaitNode, // the preceeding await that spawned this new work
previous: null | AwaitNode | UnresolvedAwaitNode, // the preceding await that spawned this new work
};

export type PromiseNode = {
Expand Down