Remove duplicate 'Recalled to Life' book title#3238
Open
gkrimer wants to merge 1 commit intofaker-ruby:mainfrom
Open
Remove duplicate 'Recalled to Life' book title#3238gkrimer wants to merge 1 commit intofaker-ruby:mainfrom
gkrimer wants to merge 1 commit intofaker-ruby:mainfrom
Conversation
The title has appeared twice in the book title list since faker-ruby#484 (Dec 2015), when the list was bulk-replaced with titles sourced from Wikipedia. Both Reginald Hill's novel and Dickens' A Tale of Two Cities Book 1 share the name, so the source list had two entries that were pasted without deduplication. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Faker::Book.titlecan return"Recalled to Life"with twice the expected probability because it appears twice in the title list (lines 141–142 oflib/locales/en/book.yml).The duplicate has been present since #484 (Dec 2015), when the book title list was bulk-replaced with titles sourced from Wikipedia. Both Reginald Hill's novel and Book 1 of Dickens' A Tale of Two Cities share the name, so the source list had two entries that were pasted without deduplication.
This PR removes one of the two identical entries.
Checklist