Halt on errors in build_lib.sh for Catapult, Symbolic and Vivado Accelerator#1483
Open
vasdommes wants to merge 1 commit into
Open
Halt on errors in build_lib.sh for Catapult, Symbolic and Vivado Accelerator#1483vasdommes wants to merge 1 commit into
vasdommes wants to merge 1 commit into
Conversation
…lerator.
"set -e" has been already added for other backends.
It allows to print compilations errors, e.g.:
firmware/myproject.h:5:10: fatal error: ac_fixed.h: No such file or directory
5 | #include <ac_fixed.h>
instead of ignoring them and crashing later, e.g.:
firmware/myproject-0b348075.so: cannot open shared object file: No such file or directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds missing
set -etobuild_lib.shscripts for Catapult, Symbolic and Vivado Accelerator.This allows them to fail early and print informative error messages. For example, is Catapult is not installed, now build script fails with:
Without
set -e, build script ignores compilation error, exits with code 0 and hls4ml fails later with more obscure error, e.g.:Type of change
Minor change that improves error logging.
Tests
Test Configuration:
I ran tests as usual, e.g.
Checklist
pre-commiton the files I edited or added.