fix: harden summary editor mount and tiptap content normalization#4699
Open
ComputelessComputer wants to merge 1 commit intomainfrom
Open
fix: harden summary editor mount and tiptap content normalization#4699ComputelessComputer wants to merge 1 commit intomainfrom
ComputelessComputer wants to merge 1 commit intomainfrom
Conversation
- guard caret-position checks until the TipTap editor view is mounted - normalize parsed markdown and loaded TipTap JSON into schema-valid documents - validate shared TipTap content with ProseMirror check() and add regressions for list and image edge cases
✅ Deploy Preview for char-cli-web canceled.
|
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two summary-editor failures behind #4696 and #4695.
This guards caret-position checks until the TipTap view is actually mounted, which prevents the
coordsAtPoscrash during mount/remount while AI summary generation swaps views. It also normalizes AI-generated markdown and stored TipTap JSON into schema-valid documents before loading them, which repairs invalid list and image structures that were failing ProseMirror schema checks.Closes #4696
Closes #4695