chore: cargo clippy fixes (all changes already on main)#4702
Closed
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
Closed
chore: cargo clippy fixes (all changes already on main)#4702devin-ai-integration[bot] wants to merge 3 commits intomainfrom
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
Conversation
Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for char-cli-web canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
Co-Authored-By: bot_apk <apk@cognition.ai>
use tauri::Manager import
Co-Authored-By: bot_apk <apk@cognition.ai>
use tauri::Manager import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ran
cargo clippy --fixand applied suggested fixes across 7 files (unused imports, collapsible if-let chains, needless lifetimes, redundant allocations). After mergingmain, all fixes were already applied upstream — this PR has an empty diff againstmainand can be closed.What happened
cargo clippy --fixauto-fixed 7 files, including removinguse tauri::Managerinapps/desktop/src-tauri/src/lib.rstauri::Managerremoval broke macOS CI —webview_windows()requires that trait in scope (only compiled under#[cfg(target_os = "macos")], so clippy on Linux didn't catch it)main, the remaining clippy fixes were already applied by other PRsmainReview & Testing Checklist for Human
main. All clippy fixes are already applied.Notes
use tauri::Manageris not unused — it provides trait methods likewebview_windows()used in#[cfg(target_os = "macos")]blocks.cargo clippyon Linux incorrectly flags it because those blocks are not compiled.Link to Devin session: https://app.devin.ai/sessions/62a8c121e30d43d88645e5e5352ceec7