themes: lift muddy accent colors to a 3:1 legibility floor#2
Merged
Conversation
Six themes had chromatic ANSI colors below ~3:1 contrast against their own background, rendering as hard-to-read syntax/prompt tokens. Each is lifted in OKLCH -- holding hue (identity preserved), moving only lightness to clear the floor -- with the matching prompt/PSReadLine values kept in sync: neon-rain purple 2.2->3.1, umbrella purple 2.4->3.1, gitbash yellow 2.7->3.1 and brightYellow 2.4->3.1 (darkened, light bg), rain red 2.6->3.1, snowday blue 2.6->3.1, golden-forest blue 2.7->3.1. umbrella's signature red (#b41e1e, 2.99) is intentionally left as-is: it drives the whole theme's banner/prompt/cursor and lifting it would shift the theme's identity for an imperceptible contrast gain. Adds tests/Scheme-Contrast.Tests.ps1, asserting every chromatic scheme color stays >=3:1 on its background (umbrella/red a documented exception) so future themes can't reintroduce muddy colors. Full suite green on pwsh 7 and Windows PowerShell 5.1 (387/387). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Six bundled themes had chromatic ANSI colors below ~3:1 contrast against their own background — they render as hard-to-read syntax/prompt tokens. This lifts each just past the 3:1 floor.
#5a4870→#6c6279#8b3030→#815350#a6a000→#9b961d#c4a500→#ad9000#a85850→#a26d66#3a6890→#44739b#4d5d3a→#566743How
Each color is lifted in OKLCH — hue held constant (identity preserved, hue shift <1°), only lightness moved to clear the floor (brighter on dark themes; darker on gitbash's white bg). Matching prompt / PSReadLine values are synced (gitbash yellow, rain red, snowday blue).
Notes
umbrella red(#b41e1e, 2.99) intentionally left — it's the theme's signature blood-red (banner/prompt/cursor); lifting it would change the theme's identity for an imperceptible gain. Documented as the one allowlisted exception.Verification
tests/Scheme-Contrast.Tests.ps1(191 cases) asserts every chromatic scheme color stays ≥3:1 on its background, so future themes can't regress.🤖 Generated with Claude Code