Skip to content

fix: Make pytest config compatible with newer pytest#5779

Open
antznette1 wants to merge 5 commits intofeast-dev:masterfrom
antznette1:fix/pytest-windows-test-config
Open

fix: Make pytest config compatible with newer pytest#5779
antznette1 wants to merge 5 commits intofeast-dev:masterfrom
antznette1:fix/pytest-windows-test-config

Conversation

@antznette1
Copy link
Copy Markdown
Contributor

@antznette1 antznette1 commented Dec 16, 2025 •
edited by devin-ai-integration Bot
Loading

What this PR does / why we need it:

  • Update sdk/python/pytest.ini to avoid relying on internal _pytest.warning_types.* warning classes (breaks on newer pytest).
  • Fix Windows multiprocessing start method selection (sys.platform is win32, not windows).
  • Avoid importing optional integration-only dependencies at conftest.py import time (so test collection doesn’t hard-fail when optional deps aren’t installed).

Why we need it:

  • Unblocks local test runs on newer pytest versions and improves Windows contributor experience.

Testing

  • Local: verified pytest no longer fails early due to invalid warning class / Windows fork start method.
Open with Devin

@antznette1 antznette1 requested a review from a team as a code owner December 16, 2025 16:38
@ntkathole ntkathole changed the title fix: make pytest config compatible with newer pytest fix: Make pytest config compatible with newer pytest Dec 23, 2025
@ntkathole ntkathole force-pushed the fix/pytest-windows-test-config branch from e5ef90b to 99c742d Compare December 23, 2025 07:59
@ntkathole
Copy link
Copy Markdown
Member

ntkathole commented Dec 23, 2025

@antznette1 Can you please fix the linting ? Thanks

@antznette1 antznette1 force-pushed the fix/pytest-windows-test-config branch from 081c356 to 1835d0f Compare January 3, 2026 01:13
@antznette1
Copy link
Copy Markdown
Contributor Author

antznette1 commented Jan 3, 2026

@antznette1 Can you please fix the linting ? Thanks

@ntkathole

I have done it.

@franciscojavierarceo
Copy link
Copy Markdown
Member

franciscojavierarceo commented Jan 3, 2026

@antznette1 looks like you need to resolve conflicts please.

@franciscojavierarceo
Copy link
Copy Markdown
Member

franciscojavierarceo commented Jan 16, 2026

@copilot can you help resolve the conflicts and remove the commits not related to this branch?

@antznette1
Copy link
Copy Markdown
Contributor Author

antznette1 commented Jan 24, 2026

@antznette1 looks like you need to resolve conflicts please.

Good day Sir,
Please, I'd love to get the review on the PR

@franciscojavierarceo
Copy link
Copy Markdown
Member

franciscojavierarceo commented Jan 25, 2026

@antznette1 there are quite a number of conflicts that need to be resolved 😅

@antznette1 antznette1 force-pushed the fix/pytest-windows-test-config branch from 1835d0f to 11f0ff0 Compare January 26, 2026 15:37
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@antznette1
Copy link
Copy Markdown
Contributor Author

antznette1 commented Jan 26, 2026

@antznette1 there are quite a number of conflicts that need to be resolved 😅

I have worked on the conflicts; it's not conflicted anymore

@antznette1 antznette1 force-pushed the fix/pytest-windows-test-config branch from 11f0ff0 to 2abd8be Compare January 26, 2026 16:21
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@antznette1 antznette1 force-pushed the fix/pytest-windows-test-config branch from 30da656 to 8a60f75 Compare February 4, 2026 11:13
@ntkathole ntkathole force-pushed the fix/pytest-windows-test-config branch from 8a60f75 to 6c504a8 Compare February 4, 2026 11:36
@antznette1
fix: make pytest config compatible with newer pytest
4b8b232 
Signed-off-by: amiraifori <iforiamira@gmail.com>
Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
Signed-off-by: Anthonette Adanyin <106275232+antznette1@users.noreply.github.com>
@antznette1 antznette1 force-pushed the fix/pytest-windows-test-config branch from 6c504a8 to 06b64f4 Compare March 31, 2026 23:47
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@antznette1
Update conftest.py
4669ee6 
Signed-off-by: Anthonette Adanyin <106275232+antznette1@users.noreply.github.com>
Signed-off-by: antznette1 <Ochiezeanthonette@gmail.com>
Signed-off-by: antznette1 <ochiezeanthonette@gmail.com>
@antznette1 antznette1 force-pushed the fix/pytest-windows-test-config branch from c5ad043 to 4669ee6 Compare April 1, 2026 01:10
@antznette1
Copy link
Copy Markdown
Contributor Author

antznette1 commented Apr 1, 2026

@ntkathole ,
Checks complete

@antznette1
Copy link
Copy Markdown
Contributor Author

antznette1 commented Apr 11, 2026

@ntkathole ,
Please can I get a review to this PR?

@antznette1
Copy link
Copy Markdown
Contributor Author

antznette1 commented Apr 19, 2026 •
edited
Loading

Good day,
please, I am still waiting for a review on this PR

@antznette1
Copy link
Copy Markdown
Contributor Author

antznette1 commented Apr 30, 2026

Hello

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@franciscojavierarceo franciscojavierarceo Awaiting requested review from franciscojavierarceo

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antznette1 @ntkathole @franciscojavierarceo