feat(cli): Add feast projects delete command (closes #5095)#6318
Conversation
|
Thanks for the detailed review, @devin-ai-integration! Fixed both issues in commit 21f7f6a:
The only new code is the |
|
Hi team! Friendly ping on this PR — all 18 CI checks are passing and there are no conflicts with the base branch. This adds a |
|
Hi team! 👋 Friendly ping on feast #6318 — this adds Status as of today:
The only blocker is maintainer CI approval + code review. Happy to address any feedback! |
cfe215b to
9f45a4b
Compare
|
@mailtoboggavarapu-coder I think it's better to include delete_project method in sdk/python/feast/feature_store.py See #6212 Let's add it to feature_store.py and remove context passing in cli |
|
Hi @ntkathole 👋 — all unit tests, smoke tests, and most integration tests are now passing after the indentation fix. Two checks are failing but neither is caused by this PR's changes:
Could you please re-run the |
Exposes project deletion via the CLI. The new `feast projects delete <name>` command calls store.registry.delete_project() which is already implemented in all concrete registries. - Adds interactive confirmation prompt with --yes/-y flag for scripting - Catches both FeastObjectNotFoundException and ProjectNotFoundException - Exits with code 1 for non-existent projects Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
…tation Addresses Devin Review findings: - Fix project_list: use utils.tags_list_to_dict() instead of manual tag.split(), and print tabulated output matching master - Fix project_current: call store.get_project(name=None) with error handling instead of store.project Both functions now match master branch exactly. Only project_delete is new code from this PR. Signed-off-by: Venkateswarlu Boggavarapu <mailtoboggavarapu@gmail.com>
Refactor project listing and deletion commands in CLI.
Added a method to delete a project from the registry.
2babaa0 to
5d6419a
Compare
Summary
Closes #5095
Exposes project deletion through the CLI by adding a new
feast projects delete <name>subcommand to the existingprojectsgroup.What's changed
Added
project_deletecommand tosdk/python/feast/cli/projects.py:Design notes
store.registry.delete_project(name, commit=True)via the lazy-initregistryproperty (the abstract method exists inBaseRegistryand is implemented in all concrete registries)click.confirm— can be skipped with--yes/-yfor scriptingFeastObjectNotFoundExceptionandProjectNotFoundExceptionso the CLI exits cleanly (exit code 1) for either variant raised by concrete registry implementationsprojects.pyExample
Checklist
deletecommand toprojects_cmdgroup--yesbypass flagprojects.py