fix: make disconnected states validation hierarchy-aware#573
Merged
fix: make disconnected states validation hierarchy-aware#573
Conversation
The `visit_connected_states` BFS now traverses the state hierarchy: entering a compound/parallel state implicitly enters its initial children, and being in a child implies being in all ancestor states. This removes the need for `validate_disconnected_states = False` in virtually all parallel, compound, and history state examples — the flag was only needed because the validator didn't understand hierarchical entry semantics.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #573 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 33 33
Lines 4044 4051 +7
Branches 635 639 +4
=========================================
+ Hits 4044 4051 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visit_connected_statesBFS now traverses the state hierarchy: entering a compound/parallel state implicitly visits its initial children, and visiting a child state visits all ancestor states. This mirrors SCXML hierarchical entry semantics.validate_disconnected_states = Falsefrom all parallel, compound, and history state examples across tests, docs, and README — the flag was only needed because the validator didn't understand the hierarchy.