refactor(tests): replace .fail.md xfail mechanism with in-code sets#574
Merged
refactor(tests): replace .fail.md xfail mechanism with in-code sets#574
Conversation
The file-based .fail.md mechanism had issues: each .scxml generates two tests (sync + async) but the xfail mark was shared, and --upd-fail caused loops when one engine passed but the other failed. Replace with XFAIL_BOTH/XFAIL_SYNC_ONLY/XFAIL_ASYNC_ONLY sets in conftest.py. - Remove 46 .fail.md files (30 mandatory + 16 optional) - Remove --upd-fail CLI option and FailedMark class - Remove unused DebugListener and helper dataclasses - Support per-engine xfail marks via sync/async set split
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #574 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 33 33
Lines 4051 4051
Branches 639 639
=========================================
Hits 4051 4051
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.fail.mdxfail mechanism with in-codeXFAIL_BOTH/XFAIL_SYNC_ONLY/XFAIL_ASYNC_ONLYsets intests/scxml/conftest.py.fail.mdfiles (30 mandatory + 16 optional)--upd-failpytest option andFailedMarkclass