Conversation
* fix(firestore-bigquery-export): correct database region param * fix(firestore-shorten-urls-bitly): fix database region * fix(firestore-shorten-urls-bitly): make db region mutable
There was a problem hiding this comment.
Pull Request Overview
This PR releases version 0.2.1 of both the firestore-shorten-urls-bitly and firestore-bigquery-export extensions with fixes to the database region parameters and adjustments to parameter mutability.
- Bumped version numbers from 0.2.0 to 0.2.1
- Updated region select options labels and values
- Changed region parameter immutability from true to false
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| firestore-shorten-urls-bitly/extension.yaml | Updated version, region labels, and made the region parameter mutable |
| firestore-shorten-urls-bitly/CHANGELOG.md | Changelog updated to record the fixes and version bump |
| firestore-bigquery-export/extension.yaml | Updated version, region labels, and made the region parameter mutable |
| firestore-bigquery-export/CHANGELOG.md | Changelog updated to record the fixes and version bump |
Comments suppressed due to low confidence (3)
firestore-shorten-urls-bitly/extension.yaml:239
- Since the region parameter is now mutable, please ensure that unit tests cover scenarios where the region may be updated.
immutable: false
firestore-bigquery-export/extension.yaml:315
- Since the region parameter is now mutable, please ensure that unit tests cover scenarios where the region may be updated.
immutable: false
firestore-bigquery-export/CHANGELOG.md:7
- [nitpick] Consider using a colon instead of a hyphen for the changelog entry to maintain consistent formatting (e.g., 'feat: migrate to v2 functions and support non-default firestore instances').
feat - migrate to v2 functions and support non-default firestore instances
cabljac
added a commit
that referenced
this pull request
Apr 22, 2025
Merge pull request #2384 from firebase/next
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.